4467: Uploading File dialog triggers a JavaScript error if it can't communicate with the web server

chipx86

What version are you running?

3.0 dev

What's the URL of the page containing the problem?

/r/123/

What steps will reproduce the problem?

  1. Open the Upload File dialog (either a new file using the Update -> Add File menu or by updating an existing file through Update File on a thumbnail)
  2. Kill the dev server
  3. Attempt to upload the file

What is the expected output? What do you see instead?

The code ungracefully fails with the following error:

uploadAttachmentView.js:72 Uncaught TypeError: Cannot read property 'err' of null

What operating system are you using? What browser?

Chrome (but any should trigger this)

chipx86
#1 chipx86
  • -New
    +Confirmed
  • +Release-2.5.x
  • -Priority:Medium
    +EasyFix
    +Priority:Low
#2 nicho

Claiming for easyfix

chipx86
#3 chipx86

Fixed on release-2.5.x (751d099788495f7f9b951a8e418f6f3ec3ad1851). Thanks!

  • -Confirmed
    +Fixed