4434: Creating a new comment discards any existing unsaved draft comments

chipx86

What version are you running?

2.0.x-2.5.x

What's the URL of the page containing the problem?

/r/id/diff/

What steps will reproduce the problem?

  1. Click a line and enter some text for the comment, but don't save.
  2. Click another line to create a new comment.

What is the expected output? What do you see instead?

The page should warn when you're about to create a new comment and lose the old one. Instead, it silently closes the old dialog and creates a new one, losing the old comment.

What operating system are you using? What browser?

Any browser.

chipx86
#1 chipx86
  • -New
    +Confirmed
  • +Release-2.0.x
    +Release-2.5.x
  • +Component:DiffViewer
    +EasyFix
    +Usability
gmyers
#2 gmyers

Perhaps https://hellosplat.com/s/beanbag/tickets/4373/ could be worked at the same time as they both involve losing un-saved comments.

#3 joycezhou

Working on this one.

brennie
#4 brennie
  • +joycezhou
david
#5 david
  • -joycezhou
#6 giuliacm

I'll take this one!

david
#7 david

This was fixed in release-3.0.x (555beefff7) and shipped in 3.0.

  • -Confirmed
    +Fixed