4428: General comments do not fully support Comment Severity extension


What version are you running?

3.0 alpha 0 (dev)

What's the URL of the page containing the problem?


What steps will reproduce the problem?

General comments can be added in two ways: 1) By clicking "Add Comment" on the review request action bar, or 2) in the Review dialog by clicking The "Add Comment" button.

When adding a general comment via method 1, the severity choice (Major, Minor, Info) can be set as it is typically for diff comments, and this severity is reflected in the published review.

However, when adding a general comment via method 2 the severity choice does not appear to be saved as it does not show on the published review. Checking the database confirms that the severity data is not serialized into extra data as it is for method 1. Additionally, for this method the severity drop down allows for choosing no severity level, whereas that is not an option for any other comments. This may be a secondary issue, or it may be a "feature" of general comments?

While this is written specifically against the Comment Severity extension, it is likely this issue would cause problems for any extensions that utilizes the CommentDetailDisplayHook.

An animation of this problem is attached. The specific steps taken in this example are outlined below, although I doubt steps one and two are really necessary.

  1. Add any diff comment and set a severity level.
  2. Add a general comment by clicking "Add Comment" on the review request action bar. Set a severity level
  3. Click Review on action bar to enter review dialog.
  4. Add a general comment in the review dialog by clicking the "Add Comment" button. Set a severity level.
  5. Publish review.
  6. Examine published review.

What is the expected output? What do you see instead?

Severity should be indicated in the published review, regardless of how the general comment was opened.

What operating system are you using? What browser?

CentOS 7

Please provide any additional information below.

#1 jamie
  • +Release-3.0
#2 david
  • +EasyFix
#3 zerotani

Graham. I'll attempt this

#4 david

Fixed in rb-extension-pack master (b13eff9). Thanks!

  • -New