4422: Duplicate "This file contains only whitespace changes."


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Create a review request with code changes
  2. Create a new revision where a file only has whitespace changes from the previous revision
  3. Open the interdiff between those revisions
  4. Expand or collapse sections in the file

What is the expected output? What do you see instead?

When it expands or collapses, it does that fine. However, it also creates a duplicate "This file contains only whitespace changes." line at the top of the file. If you expand or collapse multiple times, you get one duplicate line added each time.

What operating system are you using? What browser?

Windows 7, Firefox

Please provide any additional information below.

I was going to attempt to recreate on the demo.reviewboard.org site to see if it is an issue in 3.0. However, the demo site is currently erroring out with a "Something broke! (Error 500)" any time I try to log in...

#1 chipx86
  • -New
  • +Release-2.0.x
  • +Component:DiffViewer
  • +chipx86
#2 chipx86

Fix up for review at https://reviews.reviewboard.org/r/8799/

  • -Confirmed
#3 chipx86

Fixed on release-2.0.x (4f5e2f5d0179de90b0c6fb8be9efe345109669dc)

  • -PendingReview
#4 chipx86
  • -Interdiffs