4404: "Start Over" in Update Diff popup creates a new review instead

kyz
Connor-Y 
What version are you running?


ReviewBoard 2.5.4


What's the URL of the page containing the problem?


/r/1234


What steps will reproduce the problem?


    

  1. On an existing review, select Update -> Update Diff
    2. 

  2. Select a diff file
    3. 

  3. Click 'Start Over'
    4. 

  4. Select the diff file again
    5. 

  5. Enter the base directory and press OK
    6. 



What is the expected output? What do you see instead?


Expected behaviour: existing review request is updated with new diff and put in draft status


Actual: new review request is created using uploaded diff, existing review request is not updated




What operating system are you using? What browser?


Server is running RHEL 6, Python 2.6

Browser is Firefox 46.0


Please provide any additional information below.


Workaround: to get the behaviour of "I want to start over with uploading this updated diff", press Cancel and then choose Update -> Update Diff again
david
#1 david 
I suspect this is relatively easy to fix but I haven't actually investigated the bug.
  • +Component:WebUI
    +EasyFix
#2 Connor-Y 
Working on it.
brennie
#3 brennie
  • +Connor-Y
#4 Connor-Y 
Note: The steps to reproduce the error are incorrect.

In step 2 you must upload an improper diff (or non-diff) file to get reviewboard to display 'Start Over'. Doing so will generate the error.

The proper steps are:

1. On an existing review, select Update -> Update Diff

2. Select a non-diff file 

3. Click 'Start Over'

4. Select the diff file again

5. Enter the base directory and press OK
brennie
#5 brennie 
The fix for this has landed as 33ae4297421d797fb31e842d31c242f35e6a3600.
  • -New
    +Fixed