david

44: Keyboard shortcut for commenting on a selected block

david
Feb. 9, 2014 
The diff viewer has keyboard shortcuts for navigating throughout the diff,
but nothing for adding comments.  It'd be nice to add these.
chipx86
#1 chipx86 
The problem is that we can't select individual lines, so you'd only end up creating a
comment box for the first line in a chunk.
david
#2 david
  • +Component-DiffViewer
david
#3 david
  • +Confirmed
#4 zach****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Suggestion: A key to toggle between "block navigation" and "line navigation" mode. In block navigation, hitting 
the "new comment" hotkey would create a comment for the block, and in line mode, you could use shift-
<direction keys> to expand a selection to multiple lines and comment on them. (I realize this is probably a 
bunch of work, but eventually it might itch enough for someone to scratch.)
david
#6 david
  • +EasyFix
#8 edwin.zh********@gmai***** (Google Code) (Is this you? Claim this profile.) 
i'll work on this
david
#9 david 
Fixed in master (149ba95). Thanks!
  • -Confirmed
    +Fixed