4394: creating <style> elements for each file on the diff view can result in poor performance

glob
4389 
What version are you running?


2.5.4


What's the URL of the page containing the problem?


https://reviewboard.mozilla.org/r/20953/diff/1


What steps will reproduce the problem?


    

  1. visit url in firefox
    2. 



Please provide any additional information below.


firefox has a lot of issues rendering a review board diff view when there are 70 files.  see https://bugzilla.mozilla.org/show_bug.cgi?id=1213122#c13 for details.


the firefox developers are working on improving the situation, however they said the situation could be improved by some changes to review board.  after some discussion with both review board and firefox developers, it appears that if the styles were inlined onto the element instead of in a <style> block it would result in a better experience.
chipx86
#1 chipx86
chipx86
#2 chipx86 
Oops.
  • -shuaisha