4373: ESC key deletes the comment pop-up and all the text in it


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. While in the "diff" view of a review, click on a line number to open the comment pop-up.
  2. Enter some text (preferably something you've put a lot of thought and time into).
  3. Hit the ESC key when you're done typing because vim actions are permanently burned into your muscle memory.
  4. Watch the pop-up disappear, along with all of your work.

What is the expected output? What do you see instead?

Reviewboard should not bind to the ESC key at any point. There is already a "Cancel" button next to all text fields for this purpose.

Failing that, the user could be prompted to confirm that they really want to throw their work away. This was fixed for the review description text box in https://hellosplat.com/s/beanbag/tickets/1877/.

What operating system are you using? What browser?

Ubuntu 15.10, Firefox 45.0

Please provide any additional information below.

#1 xelepart

Not sure how prioritization works yet, but +1 -- this bothers a lot of people where I work.

#2 david
  • +EasyFix
#3 stensby

Working on this

#4 david

Fixed in release-2.5.x (337e763). This shipped in 2.5.7.

  • -New