4191: "Error displaying this diff" for most files that are posted.

gdgray 
What version are you running?


2.5.3


What's the URL of the page containing the problem?


http:/someserver//r/3/diff/1#index_header


What steps will reproduce the problem?


    

  1. rbt post
    2. 

  2. Go to ReviewBoard
    3. 

  3. Try to display the diff
    4. 





What is the expected output? What do you see instead?


I expect to see the code diffs. Instead I see the error message: There was an error displaying this diff.


The patch to 'HelloWorldServlet.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.mtRXnR' for debugging purposes.



patch returned: 


 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.

 Please try again, and if you still have trouble,
 contact support.



What operating system are you using? What browser?


Ubuntu 14.04, Chromium


Please provide any additional information below.


I've checked the diff files in the temp directory, they look fine. Uploading below.
HelloWorldServlet.java.diff 
diff --git a/HelloWorldServlet.java b/HelloWorldServlet.java
index b1731606c4bb3239e30ac73f58acd5402f953ff9..7a9ae6543154fc84cd18eec55957cbff15274532 100644
--- a/HelloWorldServlet.java
+++ b/HelloWorldServlet.java
@@ -16,6 +16,7 @@ public class HelloWorldServlet extends HttpServlet {
     /** {@inheritDoc} */
     @Override
     public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
-        response.getWriter().println("<p>Hello World!</p>");
+        System.out.println("hi");
+        response.getWriter().println("<p>Hello Earth!</p>");
     }
 }
tmp9VCNRd-new.rej 
--- HelloWorldServlet.java
+++ HelloWorldServlet.java
@@ -16,6 +16,7 @@
     /** {@inheritDoc} */
     @Override
     public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
-        response.getWriter().println("<p>Hello World!</p>");
+        System.out.println("hi");
+        response.getWriter().println("<p>Hello Earth!</p>");
     }
 }
#1 vjash 
I also have the same error. There are no problems with the diffs. I am able to patch the diff perfectly without any errors. But there is an error whiel displaying the diff on reviewboard. How to go about it?
david
#2 david 
This is usually an issue with fetching the original version of the files. If you look at the temporary files, check the orig versions to see that they match your expectation. If they don't, it's probably a misconfiguration of the repository in the Review Board admin.


Since this is (almost) always an error in configuration or set-up, I'm going to close this. We can continue to assist you on the community mailing list (https://groups.google.com/forum/#!forum/reviewboard)
  • -New
    +SetupIssue