4156: Interdiffs with multiple renames show incorrect filenames


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Post a change that renames file 'A' to 'B'
  2. Post an update that further renames file 'B' to 'C'

What is the expected output? What do you see instead?

When viewing the interdiff from revision 2 to 3, the file show show a rename from 'B' to 'C'. Instead, it says the file was renamed from 'A' to 'B'.

The diff from r1 to r3 correctly shows 'A' renamed to 'C', and r1 to r2 correctly shows 'A' renamed to 'B'.

#1 david
  • +Interdiffs
#2 adriano

A patch for this bug is pending review at: https://reviews.reviewboard.org/r/8063/

  • -New
  • +Component:DiffViewer
  • +adriano
#3 david

Fixed in release-2.0.x (e1b232d). This will ship in 2.0.23 and 2.5.4. Thanks!

  • -PendingReview