4085: View Link of Comment Reply on Diff Page doesn't scroll to comment


This is heavily related to bug #4049
Note: This only affects comments that are a reply to a comment. Top level comments are unaffected.

What version are you running?

Observed on release 2.5.2 (local build) and 2.5.3 alpha (reviews.reviewboard.org).

What's the URL of the page containing the problem?

The actual problem is on the review request page at /r/id (e.g. https://reviews.reviewboard.org/r/7926/)

There are side effects of this wherever a reply to a comment is linked to. For example on the diff page (e.g. https://reviews.reviewboard.org/r/7926/diff/1#index_header)

What steps will reproduce the problem?

  1. Create a comment on a line number in the diff page for a review request.
  2. Reply to that comment.
  3. Go to the diff page, click in the view link for the reply.

What is the expected output? What do you see instead?

Expect for the browser to redirect to the review request page and scroll to the comment.
What happens is the browser redirects but doesn't scroll to the comment.

What operating system are you using? What browser?

Windows 10. Opera 34.

Please provide any additional information below.

Most likely the problem is that anchor tags are only created for top-level comments instead of all comments.

#1 purelogiq
  • -Priority:Medium
#2 chipx86
  • -New
  • +Release-2.0.x
  • +Component:DiffViewer
  • +Mons
#3 david

Fixed in release-3.0.x (e866ae4). Thanks!

  • -Confirmed