4084: Users without editing rights on a review request do not see the onbeforeunload dialog


What version are you running?


What's the URL of the page containing the problem?

Any review request page.

What steps will reproduce the problem?

  1. Go to any review request for which you don't have edit rights
  2. Click on "review" to create a review for the review request
  3. In the review dialog, enter some text into the header input
  4. Hit reload

What is the expected output? What do you see instead?

Because the editor was "dirty" and the data wasn't persisted, I believe we're supposed to show an onbeforeunload dialog warning the user that they might lose some data.

What operating system are you using? What browser?

Firefox Nightly 47.01a

Please provide any additional information below.

This goes for replies to reviews as well. Create a reply, put some text in without hitting "OK", and reload the page. No onbeforeunload dialog.

#1 david
  • +Component:WebUI
#2 khp

Working on this one.

#3 brennie
  • +khp
#4 david

Fixed in release-2.5.x (176916d). This will ship in 2.5.10.

  • -New