Guillaume

4078: Missing removed highlight section in file between delta diff

Guillaume 
What version are you running?


Review Board 2.5.2


What's the URL of the page containing the problem?


reviewboard-lab/r/33/diff/1-2#1


What steps will reproduce the problem?


I send you a ref file (test.txt) and two diff file


    

  1. Add ref file in your repository
    2. 

  2. Create a new review
    
2a. upload diff.diff
    3. 

  3. upload diff2.diff
    4. 



What is the expected output? What do you see instead?


if you display diff (orig - 2) you see the removed line number 9


if you display diff (1 - 2) you don't see the removed line 9 highlight, if you expend up the file you see the change one line 9 without information on the modification.




What operating system are you using? What browser?


Sever on CentOS 6


Client on windows 7

Chrome

Version 47.0.2526.111 m


Please provide any additional information below.
test.txt 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
Diff.diff 
Index: test.txt
===================================================================
--- test.txt	(revision 82842)
+++ test.txt	(working copy)
@@ -2,8 +2,8 @@
 2
 3
 4
-5
-6
+5a
+6b
 7
 8
 9
Diff2.diff 
Index: test.txt
===================================================================
--- test.txt	(revision 82842)
+++ test.txt	(working copy)
@@ -2,11 +2,10 @@
 2
 3
 4
-5
-6
+5a
+6b
 7
 8
-9
 10
 11
 12
@@ -28,8 +27,8 @@
 28
 29
 30
-31
-32
+31a
+32b
 33
 34
 35
Guillaume
#1 Guillaume 
screenshoot of Changes between revision 1 and 2
Guillaume
#2 Guillaume 
Could you status on it ?

Thanks.
Guillaume
#3 Guillaume 
Tested in version 2.5.7 -> problem Solved !


You could close this bug.


Thanks for your Job