4067: Post-commit review's diff based on SVN commit shows moved files separately as deleted and added.


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Move/rename a versioned file in an SVN local copy, then mark the changes as a move (I use TSVN's "repair move" function for this).
  2. Commit the change, then create a review request from it via the Web API.
  3. Have a look at the review request's diff in Review Board.

What is the expected output? What do you see instead?

Review Board should display the moved files side-by-side: the "deleted" state on the left, the "added" state on the right (similar to TSVN's history function).

What operating system are you using? What browser?

Win7 64bit
Firefox 43.0.4
Chrome 47.0.2526.111
IE 11.0.9600.18163

Please provide any additional information below.

I guess ticket 3851 may have been a similar issue, but since it lacks details, it's hard to tell...

#1 acsipak

Still an issue in Review Board

#2 brennie

The issue here is that when RB receives the diff from SVN, it is a seperate delete and add action for each moved file (if not, I'd love an attached diff). We're working on solving this in rbt, but its not a high priority as it requires supporting SVN 1.6 -- 1.9, each of which generates slightly different diffs.

  • -New
#3 acsipak

brennie, we're not talking about rbt, we're talking about the Web API. (I do not know if there's any difference depending on whether I create a post-commit review via rbt or via Web API.)