4035: Update Diff dialog box doesn't remember SVN "base directory" anymore.

jflambert

What version are you running?

2.5.2 (issue introduced in 2.5)

What's the URL of the page containing the problem?

Any review page

What steps will reproduce the problem?

  1. Create a review, using an SVN base directory.
  2. Update -> Update Diff
  3. Select a diff
  4. User will be asked "base directory" again.

What is the expected output? What do you see instead?

I don't think this was an issue before 2.5. I don't know if anyone ever changes base directory in the course of a review? It's annoying to my users having to type it in again.

It'd be great if there was an option to pre-fill all "base directory" boxes with a global value entered in the configuration panel. We only use a single base directory for reviews (trunk).

What operating system are you using? What browser?

Ubuntu 14.04, Chrome Version 47.0.2526.73 (64-bit)

Please provide any additional information below.