4024: local variable 'is_rr_approved' referenced before assignment

pprkut
rswanson

What version are you running?

0.7.5

What steps will reproduce the problem?

  1. have a review without "ship it!"
  2. execute "rbt land -r id --dest local -n"

What is the expected output? What do you see instead?

Create a local branch containing the review request change, or at least output a message saying it's not shipped yet.

What operating system are you using?

Linux

Attach the debug out from the command.

$ rbt land -r 8232 --dest local -n --debug
>>> RBTools 0.7.5
>>> Python 2.7.5 (default, May 29 2013, 02:28:51) 
[GCC 4.8.0]
>>> Running on Linux-3.10.17-x86_64-Intel-R-_Pentium-R-_CPU________G6950__@_2.80GHz-with-slackware-14.1
>>> Home = /home/hwiesinger
>>> Current directory = /mnt/progs/projects/skyline
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
svn: E155007: '/mnt/progs/projects/skyline' is not a working copy
---
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.master.merge
>>> Running: git config --get branch.master.remote
>>> Running: git config --get remote.origin.url
>>> repository info: Path: m2:/skyline.git, Base path: , Supports changesets: False
>>> Making HTTP GET request to http://reviews.m2.com/api/
>>> Making HTTP GET request to http://reviews.m2.com/api/info/
>>> Running: git status --porcelain --untracked-files=no
>>> Making HTTP GET request to http://reviews.m2.com/api/review-requests/8232/
Traceback (most recent call last):
  File "/usr/bin/rbt", line 9, in <module>
    load_entry_point('RBTools==0.7.5', 'console_scripts', 'rbt')()
  File "/usr/lib64/python2.7/site-packages/rbtools/commands/main.py", line 133, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/lib64/python2.7/site-packages/rbtools/commands/__init__.py", line 622, in run_from_argv
    exit_code = self.main(*args) or 0
  File "/usr/lib64/python2.7/site-packages/rbtools/commands/land.py", line 217, in main
    if not is_rr_approved:
UnboundLocalError: local variable 'is_rr_approved' referenced before assignment

Please provide any additional information below.

david
#1 david
  • +EasyFix
#2 xingc
  • +xingc
#3 xingc
  • -New
    +Confirmed
  • +Release-0.7.x
brennie
#4 brennie
  • -xingc
#5 rswanson

I'd like to take this on.

brennie
#6 brennie
  • +rswanson
david
#7 david

Fixed in release-0.7.x (51a7f7d). This shipped in 0.7.7.

  • -Confirmed
    +Fixed