4019: 'Ship It' is missing from e-mail notifications


What version are you running?

2.5.11. This was not an issue in the previous version of Review Board we were using (2.4?).

What's the URL of the page containing the problem?

no URL

What steps will reproduce the problem?

  1. submit a review with a 'Ship It' with the send email box checked

What is the expected output? What do you see instead?

expected: people subscribed to the review should get an e-mail which contains "Ship It!"
actual: "Ship It!" is missing, which doesn't help the owner of the review decide whether to ship it or not!

What operating system are you using? What browser?

Chromium 45.0/Ubuntu 14.04

Please provide any additional information below.

this used to work (e-mails used to say 'ship it' at the top), now it doesn't. assuming it's a bug.

#1 gmyers

I've posted a patch for review at https://reviews.reviewboard.org/r/7767/.

#2 brennie

The fix for this has landed and will be in all future 2.0.x and 2.5.x releases. Thanks!

  • -New