4010: Screenshots not displaying after upgrade from 2.0.20 to 2.5.1.1

jm0221
chipx86
chipx86

What version are you running?

2.5.1.1

What's the URL of the page containing the problem?

Its internal

What steps will reproduce the problem?

  1. Have a review with attachment on 1.6.16
  2. Upgrade to 2.0.20, check review with attachment and it will show
  3. Upgrade then onto 2.5.1.1, and screenshow thumbnail is fine but clicking on it won't show the file.
  4. New attachments are fine on 2.5.1.1, its just historic old ones

What is the expected output? What do you see instead?

Expect to see attached file, see nothing. Worked on jump from 1.6.16 to 2.0.20

What operating system are you using? What browser?

Firefox 42.0. Linux RH6.6

Please provide any additional information below.

On an existing review and a new file being attached they are showing. Note the directory contents and how the files are being created, which could be how it is being done now (directory 05 is new working ones, the rest are just the filename without that string prepended).

[root@bfs-dl360g7-53-xm2 05]# ls -l ../04
total 176
-rwxr-xr-x 1 apache apache 175469 Nov 4 12:18 CC_SNMPTrap.jmx
[root@bfs-dl360g7-53-xm2 05]# ls -lt
total 2124
-rw-r--r-- 1 apache apache 19925 Nov 5 10:18 d6c586a5-aedd-4d9a-8783-00001883ea48__RB1_300.jpg
-rw-r--r-- 1 apache apache 57912 Nov 5 10:18 d6c586a5-aedd-4d9a-8783-00001883ea48__RB1_600.jpg
-rw-r--r-- 1 apache apache 23472 Nov 5 10:18 d6c586a5-aedd-4d9a-8783-00001883ea48__RB1.jpg
-rw-r--r-- 1 apache apache 40951 Nov 5 10:09 b452a6ba-c754-42a0-bf8e-0996f336d0cb__RB_300.jpg
-rw-r--r-- 1 apache apache 146216 Nov 5 10:09 b452a6ba-c754-42a0-bf8e-0996f336d0cb__RB_600.jpg
-rw-r--r-- 1 apache apache 316166 Nov 5 10:09 b452a6ba-c754-42a0-bf8e-0996f336d0cb__RB.jpg
-rw-r--r-- 1 apache apache 40951 Nov 5 10:08 00170ca0-2613-49fc-a181-1e3cd644f8e2__RB_300.jpg
-rw-r--r-- 1 apache apache 146216 Nov 5 10:08 00170ca0-2613-49fc-a181-1e3cd644f8e2__RB_600.jpg
-rw-r--r-- 1 apache apache 316166 Nov 5 10:08 00170ca0-2613-49fc-a181-1e3cd644f8e2__RB.jpg
-rw-r--r-- 1 apache apache 40951 Nov 5 09:45 6e7e858f-9498-4c1a-869d-396185f582a8__RB_300.jpg
-rw-r--r-- 1 apache apache 146216 Nov 5 09:45 6e7e858f-9498-4c1a-869d-396185f582a8__RB_600.jpg
-rw-r--r-- 1 apache apache 316166 Nov 5 09:45 6e7e858f-9498-4c1a-869d-396185f582a8__RB.jpg
-rw-r--r-- 1 apache apache 40951 Nov 5 09:40 429f1b9d-c7fe-4faf-bfdf-65d3984a197b__RB_300.jpg
-rw-r--r-- 1 apache apache 146216 Nov 5 09:40 429f1b9d-c7fe-4faf-bfdf-65d3984a197b__RB_600.jpg
-rw-r--r-- 1 apache apache 316166 Nov 5 09:40 429f1b9d-c7fe-4faf-bfdf-65d3984a197b__RB.jpg

RB1.jpg is the thumbnails, RB2.jpg is all I get with no bigger version when clicking on one. This is on previously added files not at 2.5.1.1

None
None
chipx86
#1 chipx86

Fix posted for review at https://reviews.reviewboard.org/r/7843/

  • -New
    +PendingReview
  • +Release-2.5.x
  • +Component:Reviews
  • +chipx86
chipx86
#2 chipx86

Fixed on release-2.5.x (e91cfeba58f8a28ca2318415309fb7dfb1b606e4).

  • -PendingReview
    +Fixed