3998: Fields guessing does not work for GitLab repository


What version are you running?

I tried both 2.0.20 and 2.5 RC1

What's the URL of the page containing the problem?


What steps will reproduce the problem?

  1. Select Git repository (from GitLab) on the left side
  2. Click on some commit

What is the expected output? What do you see instead?

The new review request is formed but it is empty. I have both Git and SVN repositories. SVN repository works fine: all fields are filled and diff is attached. Git (from GitLab) does not work: neither description, nor diff file, are not loaded.

What operating system are you using? What browser?

Kubuntu 14.04. Chromium.

Please provide any additional information below.

Hosting service: GitLab
Service URL: http://localhost/
Account: bogdan.gureev

Repository type: Git
Repository plan: Personal
Repository name: test

SSH key is added.

#1 bogdan.gureev
  • Unable to update new review request from commit ID 87716a864f918e6a6a26dbe5e9329fccda024aee: HTTP Error 401: Unauthorized
    Traceback (most recent call last):
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/reviews/managers.py", line 150, in create
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py", line 220, in update_from_commit_id
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py", line 264, in update_from_committed_change
    commit = self.repository.get_change(commit_id)
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/scmtools/models.py", line 450, in get_change
    return hosting_service.get_change(self, revision)
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 317, in get_change
    headers={'Accept': 'text/plain'})
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/hostingsvcs/service.py", line 55, in http_get
    return self.http_request(url, method='GET', kwargs)
    File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5rc1-py2.7.egg/reviewboard/hostingsvcs/service.py", line 79, in http_request
    u = urlopen(r)
    File "/usr/lib/python2.7/urllib2.py", line 127, in urlopen
    return _opener.open(url, data, timeout)
    File "/usr/lib/python2.7/urllib2.py", line 410, in open
    response = meth(req, response)
    File "/usr/lib/python2.7/urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
    File "/usr/lib/python2.7/urllib2.py", line 448, in error
    return self._call_chain(
    File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
    result = func(
    File "/usr/lib/python2.7/urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
    HTTPError: HTTP Error 401: Unauthorized
#2 chipx86
  • -New
  • +Release-2.0.x
  • +Component:HostingServices
  • +chipx86
#3 chipx86

Change up for review at https://reviews.reviewboard.org/r/8194/

#4 chipx86

Fixed in e38497672cb0e3c9c4ced97588d51ef3aaff1694.

  • -Confirmed