3993: Stale .../diff/X-Y/fragment/... served when Y is not yet published

vladr
chipx86
chipx86
3966

What version are you running?

2.0.20

What's the URL of the page containing the problem?

n/a

What steps will reproduce the problem?

  1. Upload revision 1
  2. Publish revision 1
  3. Upload revision 2
  4. View changes, "Changes between revision 1 and 2"
  5. Upload a changed revision 2
  6. View changes, "Changes between revision 1 and 2"

What is the expected output? What do you see instead?

Expected output:
"Changes between revision 1 and 2" in step 6 should reflect the content uploaded in step 5
the "Diff Revision 2" download link should retrieve a file that reflects the content uploaded in step 5

Actual output:
"Changes between revision 1 and 2" in step 6 reflects the OLD contents still uploaded in step 4
the "Diff Revision 2" download link produces "The page you were looking for does not exist."

What operating system are you using? What browser?

Linux, Chrome

Please provide any additional information below.

So it looks as though viewing the 1-2 diff in step 4 cached thye fragments (http://hhhh/r/RRRR/diff/1-2/fragment/ffff/?index=ii&tttttttt&api_format=json) on the server-side, and uploading a new diff for revision 2 did not completely invalidate that cache. Not a browser cache issue, it's server-side. Manually altering the URL (removing api_format or changing ttttttt) returns the correct (expected) diff again.

gmyers
#1 gmyers

I think this is a duplicate of Bug 3966 (https://hellosplat.com/s/beanbag/tickets/3966/).

chipx86
#3 chipx86

Fixed on release-2.0.x (commit dd7dcbd)

chipx86
#4 chipx86

Wrong bug... Didn't mean to remove the duplicate info.

#5 vladr

Confirmed that clearing chrome's cache & cookies fixes the issue.