chipx86

3978: Users with the "can_change_status" permission be allowed to edit the close message

chipx86 
What version are you running?


2.0.x/2.5.x/master


What's the URL of the page containing the problem?


/r/id/


What steps will reproduce the problem?


    

  1. Assign a normal user the "can_change_status" permission for review requests.
    2. 

  2. Have the user close the review request.
    3. 

  3. Have the user edit the review request's close message.
    4. 





What is the expected output? What do you see instead?


The user should be allowed to edit this, as it just makes sense to be able to do that. However, they're not allowed to without also having the can_edit_reviewrequest permission, which may not be desirable.
chipx86
#1 chipx86
  • -New
    +Confirmed
  • +Release-2.0.x
  • +Component:Reviews
    +EasyFix
    +Usability
#2 darteaga
  • +darteaga
#3 darteaga 
this big is fixed. I was unable to reproduce bug on 2.5.x and it works fine on 2.0x
mconley
#4 mconley
  • -darteaga
shuaisha
#5 shuaisha
  • +shuaisha
brennie
#6 brennie
  • -shuaisha
chipx86
#7 chipx86 
Verified that this appears to be fixed.
  • -Confirmed
    +Fixed