396: Whose 'court' the review in currently in?
- Review Board
|suda*****@gmai***** (Google Code) (Is this you? Claim this profile.)|
|1924, 2530, 4478|
It'd be nice to see in the dashboard view whose 'court' the review was currently in: if the last update was a review request, it's *review pending*; if it's received feedback without a Ship It, it's *update pending*; if it's received feedback with a Ship It, it's *approved by N reviewers*.
- Type-Defect + Type-Enhancement
Sounds like a Status column would work.
#3 suda*****@gmai***** (Google Code) (Is this you? Claim this profile.)
That would work. Please also expose this bit of information through the API as well.
We're trying to keep from adding too many more features for 1.0. Unless someone wants to write a patch I'm moving this to 2.0.
#5 kevin.******@beatpo****** (Google Code) (Is this you? Claim this profile.)
I agree completely. It also makes sense that RB would be able to display who has reviewed since the patch was last updated and make it possible to determine when a review is required for approval by a particular individual or group versus a review is available to a particular group or individual (not required for approval).
#6 jeff****@gmai***** (Google Code) (Is this you? Claim this profile.)
Just throwing in my 2 cents for when someone gets around to implementing this, as this is one of the main annoyances I have with reviewboard. I spend a lot of time re-opening reviews to see what's happened. I think what people want is a "My next requested action" column. Calling it status would still work, but tailored to the next action would be best. The above comments address the issue for outgoing reviews. For incoming reviews, however, it'd be nice to see how the logged-in reviewer last addressed the review. Incoming statuses: "Review needed" "Draft review saved" "Review submitted, awaiting new diff" "Review submitted, marked as Ship It" Outgoing statuses: "Awaiting reviews" "Modifications requested, approved by N of N reviewers" "Approved by N of N reviewers" "Ready to submit"
Thanks for the 2 cents Jeff :) I just wanted to address one thing real quick. You mentioned that you spend a lot of time looking at review requests to see if anything changed. Are you using the "New Updates" column to at least only open review requests that have had changes made?
#8 jeff****@gmai***** (Google Code) (Is this you? Claim this profile.)
Yes, I am. It helps, but comes short. For example, look at this situation. I see a new update to a review, and it's a huge rewrite that's going to take some serious time to look over. I can't get to it right now, so I put it aside for later. (Maybe a "mark as unread" ability is needed to restore the new updates icon?) Now, do this once or twice and I can't trust the new updates icon anymore. I don't know the real status of anything. So I have to go through the entire list of reviews, which inevitably entails re-reading a lot of comments just to make sure I'm not inadvertently being lazy.
Yeah. I definitely agree with you. I just wanted to make sure you weren't at least randomly reloading pages without knowing if anything changed or not :)
This actually feels very closely related to Issue 739. Perhaps this will become less urgent once you can scan the "Last Updated By" column to see anything that doesn't have your username?