3926: E-mail sending failure with utf-8 characters in description

david
david
david
July 28, 2015
Sending an e-mail with 2.5beta2 fails if there are utf-8 characters in the review request description:

2015-07-22 23:35:34,565 - ERROR -  - Error sending e-mail notification with subject 'XXXXX' on behalf of '"XXXXX" <xxxxx@xxxxx>' to '"XXXXX" <xxxxx@xxxxx>'
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/ReviewBoard-2.5b2.dev20150717171306-py2.7.egg/reviewboard/notifications/email.py", line 373, in send_review_mail
    message.send()
  File "/usr/local/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/core/mail/message.py", line 276, in send
    return self.get_connection(fail_silently).send_messages([self])
  File "/usr/local/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/core/mail/backends/smtp.py", line 94, in send_messages
    sent = self._send(message)
  File "/usr/local/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/core/mail/backends/smtp.py", line 110, in _send
    self.connection.sendmail(from_email, recipients, message.as_bytes())
  File "/usr/local/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/core/mail/message.py", line 138, in as_string
    return fp.getvalue()
  File "/usr/lib64/python2.7/StringIO.py", line 271, in getvalue
    self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1217: ordinal not in range(128)
david
#1 david
  • +PendingReview
david
#2 david
Fixed in release-2.0.x (a9819cb). This will ship in 2.0.19
  • -PendingReview
    +Fixed