3925: ShipIt count should be reset whenever a new diff is uploaded
- Duplicate
- Review Board
| ste****@gallaghe********* (Google Code) (Is this you? Claim this profile.) | |
| July 22, 2015 | |
What version are you running? Review Board 2.0.18 What's the URL of the page containing the problem? The dashboard What steps will reproduce the problem? 1. Mark a review as ShipIt 2. Upload a new diff to the review What is the expected output? What do you see instead? When a new diff is updated, it's really unexpected that the old ShipIt count would remain, as this wrongfully implies that reviewers have approved of the new diff, when in fact they have not necessarily even seen it. It might mean that a committer could merge the packages into the master repository without realizing that the latest version hasn't been reviewed. What operating system are you using? What browser? Fedora 22, Firefox/Chrome Please provide any additional information below.
-
+ Duplicate -
+ 2106 - Diff updates after "ship it"
See #2106
Since 3.0 it is possible to revoke ShipIts. I added this to my extension. After someone posts an update it will revoke any previous ShipIt.
https://github.com/misery/ExtendedApproval