3921: Inter-diff viewer missing changes

command*******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
3990, 4028 
What version are you running?
2.0.18

What's the URL of the page containing the problem?
https://reviewboard.eng.vmware.com/r/842313/diff/1-2/

What steps will reproduce the problem?
1. Have some one change a review and post a new diff
2. Look at the interdiff
3. See that changes are not highlighted

What is the expected output? What do you see instead?
Removed lines should be marked as such.

What operating system are you using? What browser?
Windows 7, Firefox.

Please provide any additional information below.
See the attached screenshot. One of the lines was
removed in the change but not shown as such in review board.
chipx86
#1 chipx86 
Thanks for the report. We'll need some data on the diffs and source files for both ends of the revision sent to us through your SCM team's support contact, so we can work on diagnosing this.
  • +NeedInfo
#2 command*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I opened bug 1483833 in VMware's internal Bugzilla system for this.
In the bug I asked our IT people to provide whatever information
you need (I don't have access to our servers).
#3 jflambert 
chipx86, I also have this issue, also with 2.0.18. It actually frequently happens.


For instance some of the changes that happened in diff "1-2" are visible in "full diff" but not in "show changes" of "1-2".
#4 jflambert 
I just upgraded to 2.0.20, performed a full reindex (not necessary I know) and still same issue. We are using SVN 1.8.8 on Ubuntu 14.04.
chipx86
#5 chipx86
  • -NeedInfo
    +Confirmed
  • +Release-2.0.x
  • -Priority:Medium
    +Component:DiffViewer
    +Interdiffs
    +Priority:High
  • +chipx86
chipx86
#6 chipx86
chipx86
#7 chipx86
tstack
#8 tstack 
Here's an example on rbcommons that might be easier for you to access:


https://rbcommons.com/s/snaplogic/r/22379/diff/1-2/


If you look at jcommon/src/main/java/com/snaplogic/cc/NeighborsHolder.java it only shows the deletion of line 298, but not the accompanying right curly.


I'd appreciate some attention in the area of interdiff bugs.  If only to save me from snarky comments about reviewboard.
david
#9 david
  • -Confirmed
    +Fixed
  • -Release-2.0.x