3871: rbt post hangs when in a post-commit hook

paff*****@gmai***** (Google Code) (Is this you? Claim this profile.)
May 17, 2015
What version are you running?

What's the URL of the page containing the problem?
Our local svn server.

What steps will reproduce the problem?
I am creating a remote svn post-commit rbt post hook.

What is the expected output? What do you see instead?
I am expecting my diff to get uploaded to the review board server.
The rbt post process hangs. It stays running.

What operating system are you using? What browser?
CentOS with kernel 2.6.32-279.el6.x86_64

Please provide any additional information below.

From what I gather - the problem probably comes from the fact that the svn diff is used without the --non-interactive flag in combination with a username and password for the svn passed as arguments (with --svn-username and --svn-password). This leads to a dialog asking you whether to store the password unencrypted. I tested it with the --non-interactive flag passed to svn diff (svn.py:286) and it works as it should.
#1 david
  • +PendingReview
  • +Component-RBTools
  • +david
#2 david
Fixed in release-0.7.x (984f5e6). This will ship in 0.7.3. Thanks!
  • -PendingReview