3778: api-cache is broken for bugs_closed?

vlo****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Feb. 26, 2015
What version are you running?
0.7.1 & 2.0.13

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Create a review with the API setting bugs_closed to ['1234'] in the draft (see https://code.google.com/p/reviewboard/issues/detail?id=3777)
2. Review has a bad value for defects
3. Fix it up manually in the reviewboard website to 1234
4. Fetch the bugs_closed field via the API

What is the expected output? What do you see instead?
I expect bugs_closed to be '1234'.  Instead it's the weird serialized array still.  Clearing out the apicache.db fixed the issue.

What operating system are you using? What browser?
10.10 & python2.7

Please provide any additional information below.
#1 vlo****@gmai***** (Google Code) (Is this you? Claim this profile.)
Apparently the extra_data caching is broken as well.

This is very easily reproduced by using the "Note to reviewers extension"

1.  rbt api-get --server ... --username ... review-requests/1/draft
2.  Make a change to Note to Reviewers field (don't publish)
3.  rbt api-get --server ... --username ... review-requests/1/draft
4.  Make a different change to Note to Reviewers field (don't publish).
5.  rbt api-get --server ... --username ... review-requests/1/draft

rbt ocassionally reports old results.
chipx86
#2 chipx86
Stupid bug on our part. Fixed on Djblets release-0.8.x (89af755). We'll get this out for RB 2.0.14.
  • +Fixed
  • +Project-Djblets
    +Milestone-Release2.0.x
    +Component-API
  • +chipx86
#3 vlo****@gmai***** (Google Code) (Is this you? Claim this profile.)
Is bugs_closed the only affected?  extra_data looked to be affected as well.
#4 vlo****@gmai***** (Google Code) (Is this you? Claim this profile.)
Probably should disable caching in RBTools for anything older than 2.0.14 too!
chipx86
#5 chipx86
It's an overall bug for any field, really. We had a pretty nasty bug there.

We'll probably have RBTools disable for under 2.0.14 in the next release.