3704: Google Chrome policies prevent diffs from being downloaded in some cases

sour*****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 17, 2015
What version are you running?

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Attempt to download the diff in Google Chrome (v16 or later)
2. Get a "Multiple Content-Disposition" error page from Chrome.

What is the expected output? What do you see instead?
The diff.

What operating system are you using? What browser?
Any OS. Browser is Google Chrome.

Please provide any additional information below.

All other browsers and utilities are unaffected. 

Caused by Google Chrome policies - https://code.google.com/p/chromium/issues/detail?id=108188

The fix is to edit reviewboard/reviews/views.py, and insert the
following just below line 949.

    filename = filename.replace(',', '_')

Only occurs if the diff name is based upon the summary, and it contains a comma.
#1 david
  • +EasyFix
#2 Chester.********@gmai***** (Google Code) (Is this you? Claim this profile.)
#3 david
Fixed in release-2.0.x (f52c7c6). Thanks!
  • +Fixed