3680: Diff viewer does not indent code properly.

to***@salsita******** (Google Code) (Is this you? Claim this profile.) 
What version are you running?
2.0.11

What's the URL of the page containing the problem?
https://review.salsitasoft.com/r/9858/diff/#

What steps will reproduce the problem?
1. Post a review with tab indented files (4+ levels of indentation)
2. Open the review in the diff viewer

What is the expected output? What do you see instead?
I'd expect the indentation to be formatted correctly. Instead I see everything deeper than 3rd level aligned to a block (i.e., indented to the same level).

It makes the reviews pretty hard to read.

What operating system are you using? What browser?
Mac OSX 10.9, Chrome 39
Please provide any additional information below.
david
#1 david 
We don't have access to your private server, but this code is quite well tested. Perhaps you have a mix of tabs and spaces?
  • +NeedInfo
#2 to***@salsita******** (Google Code) (Is this you? Claim this profile.) 
Nope. Just tabs.

It happens e.g. with a diff containing the following lines https://github.com/salsaflow/salsaflow/blob/develop/prompt/prompt.go#L146-L153

(The repo is opensource so you can check it for yourselves.)
#3 to***@salsita******** (Google Code) (Is this you? Claim this profile.) 
Status is still "NeedInfo". Can I provide any more information regarding this? It should be pretty easy to reproduce with any patch from the repo in my previous post.
david
#4 david
  • -NeedInfo
    +Fixed