chipx86

3602: Master bug: Plain text is rendered incorrectly when escaping for Markdown.

chipx86
3529 
What version are you running?
2.0.x

This is the master bug for cases where the Markdown escaping is broken.

The intention is for our Markdown escaping to perfectly represent provided text (from pre-2.0 review requests, or from non-Markdown commit messages) without any artifacts (such as stray "\" symbols).

This doesn't always work perfectly due to the manner in which we're escaping. This is because, currently, we need to be compatible with Python Markdown rendering and JavaScript Marked rendering. The plan is to switch exclusively to Python Markdown rendering, which will allow us to better handle intelligent escaping, fixing most problems.

If you have a case where your text is not escaped and rendered properly, please post it here as a comment.
chipx86
#1 chipx86
#2 jameslin 
Steps to reproduce:
1. Create a review request.
2. Enter the following description:

----
1. Lorem ipsum:
   Blah blah blah
2. Lorem ipsum:
   Blah blah blah
----

Result:
The description gets transformed into:
1. Lorem ipsum:
Blah blah blah
2. Lorem ipsum:
Blah blah blah

This doesn't seem to happen with bulleted list items with *.

(This is with Review Board 2.0.6, but I also reproduced it on demo.reviewboard.org which is currently running 2.1 alpha 0.)
david
#3 david 
We haven't had any problems here for a long time.
  • -Confirmed
    +Fixed