3550: Broken behavior of revision sliders.

michal.e********@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 3, 2014
3447 
Version: 2.0.6.
URL: http://reviewboard.xx/r/501/diff/3/

Repro steps
1. Add SVN diff with one set of changes (base revision no: 100)
2. Update review request with adding SVN diff with next set of changes (base revision no: 110)
3. Try to view all changes done within that review

Expected result:
It should be possible to set the sliders to the position that allows viewing all changes (the sum of all diffs) from the review.

Actual result:
Sliders on orig and version show changes only from given revision. Sliders between revisions show changes between revisions

Reviewboard runs on Ubuntu
Client: Firefox 31 on Windows 7 x64

My ideas:
1. Change the behavior so when both sliders are on given revision changes from that revision are shown and change 'orig' to 'base' - in my opinion only this solution removes the current confusion how this works - I have to explain every new person to reviewboard how it works and why this is not intuitive.
2. Add a position before/after 'orig' with label 'base' and sliders between base and for example revision '2' would show the sum of changes from revision '1' AND '2'
david
#1 david 
I think you're misunderstanding how diff revisions are intended to be used. Rather than each revision of the diff being a separate change, they're supposed to be different iterations of the same change. This is because Review Board has traditionally been meant for a pre-commit model where multiple iterations of a change are reviewed before committing.

We do need to figure out what it means to iterate on a change in a post-commit model, but that's a long-term project. We have an open enhancement request about that, which I'm going to merge this bug into. In the meantime, the diff revision sliders are working as expected, and your best bet is to create separate review requests for each individual SVN commit. You can use the "depends on" field to link them together.