3546: Some directories not selectable in Subversion repository

tims****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 24, 2015
What version are you running?
2.0.6, upgraded from 2.0.5 via easy_install + rb-site upgrade

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Add subversion repository with uncommon structure, e.g., with trunk and branches folders but also additional ones in the root dir.
2. Open /r/new/ and select the repository
3. The drop-down box shows only a subset of the directories. In my case it shows only trunk and the directories in branches. The other directories on the same level as trunk and branches are not selectable. Hence revisions in the other directories cannot be selected for review.

What is the expected output? What do you see instead?
All directories should be selectable in the drop-down box. Alternatively, all revisions/changes should be selectable in the list without selecting any specific directory, e.g., "-----------" in the drop-down box.

What operating system are you using? What browser?
Ubuntu 14.04 for the server, Ubuntu 12.04 for the client with Firefox 31

Please provide any additional information below.
Example repository structure:

|- branches
|     |-branch1
|     |-branch2
|     |-branch2
|- foobar
|- trunk

foobar is not available in the drop-down box
#1 tims****@gmai***** (Google Code) (Is this you? Claim this profile.)
The problem already existed in 2.0.5 and is not new in 2.0.6!
#2 tims****@gmai***** (Google Code) (Is this you? Claim this profile.)
Probably related to https://code.google.com/p/reviewboard/issues/detail?id=3543
#3 bly***@gmai***** (Google Code) (Is this you? Claim this profile.)
Have a look at the get_branches function in reviewboard/scmtools/svn/__init__.py. This is not a bug but a feature designed this way by the developers.

If you need a quick workaround, just delete the "if 'trunk' in root_dirents" block and keep the former "else" block.

Maybe the developers also agree that this should be changed?!? My arguments would be:
- You cannot select a subset of the revisions if your repository structure has a trunk (and branches) dir but further directories in the root
- Subversion mandates no "standard layout" and you find many different layouts in the wild
- Even when there is a trunk (and branches) dir, the common tags dir cannot be selected for review requests
#4 tims****@gmai***** (Google Code) (Is this you? Claim this profile.)
Thanks for the hint. That's indeed a good work-around. I hope this becomes the default in future releases.
#5 david
  • +Project-ReviewBoard
#6 david
  • +PendingReview
  • +david
#7 david
Fixed in release-2.0.x (57159e6). Thanks!
  • -PendingReview