3446: ReviewRequestFieldsHook and email notfications

ke***@keithmo******* (Google Code) (Is this you? Claim this profile.)
What version are you running?

What's the URL of the page this enhancement relates to, if any?
email notifications

Describe the enhancement and the motivation for it.
ReviewBoard 2.0 added extensibility for adding custom fields to a review request.  We've embraced that and included a couple of important-to-us fields.  It would fantastic if our field hook could also indicate to be included in the various review request notification emails, alongside the description, testing, diffs, bugs, etc.

What operating system are you using? What browser?
Windows 7, Firefox 29

Please provide any additional information below.
The "rendered" value would be preferred over the text value of the field.
#1 chipx86
This is something I'd like to add. E-mails are a bit tricky, though, so we wouldn't necessarily be able to use the exact rendered value, but could probably just add a new method for getting a render for e-mail purposes that falls back on the standard rendered value.
  • +Milestone-Extensions
#2 chipx86
  • +Confirmed
#3 david
  • +Project-ReviewBoard
#4 nites*****@gmai***** (Google Code) (Is this you? Claim this profile.)
+1. Without this, I plan to just patch reviewboard/notifications/email.py and replace reviewboard/templates/notifications/review_request_email.html and reviewboard/templates/notifications/review_request_email.txt. Of course, this makes maintenance uglier.