3437: Double-clicking to Add a Comment in the Diff View Discards Any Comments Made
- UnableToReproduce
- Review Board
| pmont******@benune****** (Google Code) (Is this you? Claim this profile.) | |
| Feb. 10, 2015 |
What version are you running? 2.0.2 What's the URL of the page containing the problem? http://codereview.benunets.com/r/13/diff/# What steps will reproduce the problem? 1. From the Diff view source listing, instead of a single click to add a comment, double-click to add a comment 2. The "Your Comment" box comes up correctly and can be updated and saved BUT the comment is never actually saved. 3. After the double-click, you do see a "Comment Deleted" notice pop up quickly and disappear on the left side of screen while the "Your Comment" dialogue box appears. What is the expected output? What do you see instead? The Comment should have been saved, but it was not. What operating system are you using? What browser? MacOS Chrome Please provide any additional information below. We had one person that spent a considerable amount of time on one review double-clicking away to add all their comments only to find out that nothing was saved. This is not a critical issue by any means.
Looked into a bit. Just leaving some notes for later: It's not an issue with a double-click event, but rather that a mouse down is sees a comment flag in that position and triggers a click event on it, in order to bring back the (presumably closed) comment dialog. This is in textCommentRowSelector.js in _end(), where it calls click(). We can probably just solve this by keeping some state as to which comment flag is currently open, and not calling click() if it's already open.
-
+ Confirmed -
+ Component-DiffViewer + EasyFix + Milestone-Release2.0.x
Currently looking into this -- David Kus
I cannot reproduce this on the current release (2.0.12). Please re-open if you still experience this in the current release, and we'll dig deeper.
-
- Confirmed + UnableToReproduce