3392: Home/delete key functionality changed

ben.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 13, 2014
What version are you running?

What's the URL of the page containing the problem?
Any review request.

What steps will reproduce the problem?
1. Click the "View Diff" button on a review
2. Add a comment to the review. Enter a comment that's long enough that it has to wrap to multiple lines.
3. Press the "Home" key.

What is the expected output? What do you see instead?
I would expect the cursor to move to the first column of the current line (this is what RB v1.x did).  Instead, the cursor jumps all the way back to the beginning of the comment field, or the last manually-entered newline (whichever is closest).  The "End" key behaves similarly, except moving in the other direction.  This makes it harder to navigate around using the keyboard.

What operating system are you using? What browser?
Windows 7,  Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
This was also reproduced on IE11.

Please provide any additional information below.
#1 chipx86
This is due to using CodeMirror as our text area replacement, for Markdown support. Unfortunately, that means we're not using the native text area that the browser supplies, resulting in slightly different behavior.

It may be possible for us to fine-tune these keys for every browser on every OS, but I don't know if that's the best option. Really, I think this is something CodeMirror should address..

That said, I'm okay changing these two keys globally.
  • +Confirmed
#2 david
Fixed in release-2.0.x (501c98b). Thanks!
  • -Confirmed