3375: Diff viewewr cuts off long lines on Firefox

christia*********@gmai***** (Google Code) (Is this you? Claim this profile.)
June 20, 2014
3309
3391
What version are you running?
2.0

What's the URL of the page containing the problem?
http://myreviewboardserver/r/1234/diff/#

What steps will reproduce the problem?
1. Looking at a diff of a file which has long lines

What is the expected output? What do you see instead?

The diff viewer shows the old and new file side by side but on the new file part the lines get cut off if they are too long for the browser window (see attached screenshot). On Chrome and IE the lines get wrapped. On Firefox I would expect the same or having a horizontal scrollbar to appear would suffice as well


What operating system are you using? What browser?
Windows 8.1, FF 29.0.1, works ok on Chrome 35.0 and IE11


Please provide any additional information below.
#2 jon.ba*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Just FYI, my team has reported seeing the same behavior in chrome.
#3 bce****@gmai***** (Google Code) (Is this you? Claim this profile.)
This is a serious issue for us that keeps us from migrating to newest release. The old RB had a horizontal scroll bar available when the lines exceeded screen width. At this moment all those reviews are not readable - even on full HD I am seeing only half of the diff viewer with no option to scroll the screen horizontally.

We are reviewing C++ code on RB and it is very likely to have somewhere a long line which cannot be broken by the diff viewer.
chipx86
#4 chipx86
Can you also provide screenshots? I also need to see the line that's causing it to go so wide. I'm also curious how it looked on the older release (which release was that?)

Lines will only grow so wide if they have a long non-wrappable string of that width.

As far as I'm aware, these are not new problems, but rather something that users with very long strings in diffs have always had to deal with when using Firefox.
  • +NeedInfo
  • +Component-DiffViewer
chipx86
#5 chipx86