3361: Nitpick: Diff file icon is bigger than the spinner it replaces

ch***@orr.***** (Google Code) (Is this you? Claim this profile.)
May 21, 2014
What version are you running?
- Review Board 2.0

What's the URL of the page this enhancement relates to, if any?
- /r/X/diff/#index_header

Describe the enhancement and the motivation for it.
- While waiting for the diff summary to load, there is a spinner for each file in the diff. Once the diff info has loaded, the small diff circle indicator is displayed for that file.

However, this is ~four pixels larger than the spinner, causing the whole page to jump down slightly as each indicator is shown.
This is most noticeable if there are a lot of files touched in a review request, or if you reload the page while looking at a diff further down the page.

It would be nice if the spinner was the same size as the icon.

What operating system are you using? What browser?
- Chrome 34 on Linux
#1 chipx86
  • +Started
  • +Milestone-Release2.0.x
  • +chipx86
#2 chipx86
Fix up at https://reviews.reviewboard.org/r/5853/
  • -Started
#3 chipx86
Fixed on release-2.0.x (1a9fc1c)
  • -PendingReview