3335: RBTools - Perforce - no diffs generated for committed changelist

e.smol******@gmai***** (Google Code) (Is this you? Claim this profile.)
May 9, 2014
What version are you running?
RBTools 0.6

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. Perforce repository: rbt post <submitted change #>
2.
3.

What is the expected output? What do you see instead?
Diffs are generated and a new review request is submitted. Instead, the following error is shown:

rbtools.commands.CommandError: There don't seem to be any diffs!

What operating system are you using? What browser?
Solaris

Please provide any additional information below.
There is a missing call to self._do_diff in perforce.py in the _compute_range_changes method within the "action == 'edit'" branch of the if/elif/else statements. I think the following should be added there:


diff_lines += self._do_diff(
    old_file, new_file, initial_depot_file, initial_rev,
    depot_file, 'M', ignore_unmodified=True)
david
#1 david
Fixed in rbtools master (036ca7d). Thanks!
  • +Fixed