3334: RBTools - GNU diff check should check for Solaris

e.smol******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
May 13, 2014
What version are you running?
RBTools 0.6

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. On a Solaris system try to run rbt post with gdiff installed.
2.
3.

What is the expected output? What do you see instead?
Expect a new review request to be created. Instead the following error is shown:
GNU diff is required in order to generate diffs.

What operating system are you using? What browser?
Solaris

Please provide any additional information below.
On a Solaris system, GNU diff is installed as gdiff. The checks.py module should check for Solaris and use the correct binary name as it does in perforce.py

if hasattr(os, 'uname') and os.uname()[0] == 'SunOS':
    diff_cmd = "gdiff"
else:
    diff_cmd = "diff"
david
#1 david
  • +PendingReview
  • +Component-RBTools
  • +david
david
#2 david
Fixed in rbtools master (d82983f). Thanks!
  • -PendingReview
    +Fixed