3316: Don't email yourself

nlas*****@landmarkg********* (Google Code) (Is this you? Claim this profile.)
Oct. 19, 2014
What version are you running?

2.0 RC2

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.

I'm tired of getting emails when I submit a comment or a request. I did the action, ReviewBoard shouldn't email me, it should only email everyone else.

What operating system are you using? What browser?


Please provide any additional information below.

I implemented this for my system. It requires the following changes:

In admin/forms.py, add this to the EMailSettingsForm:

    mail_do_not_send_to_self = forms.BooleanField(
        label=_("Exclude the person doing the action when review emails are sent"),

In notifications/email.py, add this to send_review_mail

    if siteconfig.get("mail_do_not_send_to_self"):
        if (from_email in recipients):

        if (from_email in to_field):

before these lines:

    # Set the cc field only when the to field (i.e People) are mentioned,
    # so that to field consists of Reviewers and cc consists of all the
    # other members of the group
    if to_field:
        cc_field = recipients.symmetric_difference(to_field)
#1 david
If you want to contribute a patch, please post it on https://reviews.reviewboard.org

Ideally this would be a user profile preference, rather than a global admin toggle.
#2 ch***@orr.***** (Google Code) (Is this you? Claim this profile.)
I agree that this should be a user preference, but at every company where I've used RB, most people set up email filters to auto-delete these emails — so it would be great if this preference was disabled by default (i.e. do not enable "Remind me via email what I just did a second ago" by default).
#3 david
Added a preference for this in release-2.0.x (baa89ce). Thanks!
  • +Fixed