3305: ValueError: "need more than 1 value to unpack" when uploading diff for ClearCase

david.ga*********@gmai***** (Google Code) (Is this you? Claim this profile.)
April 16, 2014
What version are you running?

What's the URL of the page containing the problem?

What steps will reproduce the problem?

1. Generate a diff file with appropriate metadata.
2. Navigate to /r/3787/ where 3787 is a review request for a ClearCase repo.
3. Use the "Update Diff" option. Fill in the form.
4. Press "Upload".

What is the expected output? What do you see instead?

Expected: I can update the diff without errors.
I see: "need more than 1 values to unpack"

What operating system are you using? What browser?

Linux, Firefox
(Although it doesn't matter.)

Please provide any additional information below.

The problem is that the diff file doesn't have a version selector in the second filename. That causes

    path, version = filename.split("@@", 1)

to produce

    ValueError("need more than 1 values to unpack")

for said filename. ("@@" is the separator between the file name and the version.)

I'm posting a fix for the above issue momentarily.
#1 david.ga*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Fix for issue is on reviewboard: https://reviews.reviewboard.org/r/5713/diff/
#2 david
Fixed in release-2.0.x (4fcd696). Thanks!
  • +Fixed