3303: PySVN integration broken in Review Board 2.0 RC2 - 1 line code fix included

nlas*****@landmarkg********* (Google Code) (Is this you? Claim this profile.)
April 16, 2014
What version are you running?

2.0 RC2


What's the URL of the page containing the problem?

First found at /admin/db/scmtools/repository/add/, but it's everywhere


What steps will reproduce the problem?
1. Install a system with Review Board 2.0 RC2
2. Install pysvn and not subvertpy
3. Try to interact with Subversion

What is the expected output? What do you see instead?

I expect Review Board to work. Instead, I see "Authentication Failed" errors

What operating system are you using? What browser?

CentOS 6

Please provide any additional information below.

I dug into the problem and found that the user name and password is not being passed to pysvn.

Editing:

/usr/lib/python2.6/site-packages/ReviewBoard-2.0rc2-py2.6.egg/reviewboard/scmtools/svn/__init__.py

Around line 300, is the line:

client = Client(config_dir, repopath)

This creates a new PySVN client with no credentials. Changing it to:

client = Client(config_dir, repopath, username, password)

Solves the problem.
david
#1 david
Fixed in release-2.0.x (6f5d19a). Thanks!
  • +Fixed