3280: Next/Previous keyboard shortcuts should honor "Hide Whitespace Changes"

ke***@keithmo******* (Google Code) (Is this you? Claim this profile.)
March 18, 2014
What version are you running?

What's the URL of the page this enhancement relates to, if any?

Describe the enhancement and the motivation for it.
There exists an option to hide whitespace changes, which is really helpful when reviewing changes where someone also did a bunch of cleanup.  However, the hotkeys (n, p) still hit every single change.

The hotkeys should either skip the "dimmed" changes ) or another set of hotkeys should be introduced.

What operating system are you using? What browser?
Windows 7, Firefox.

Please provide any additional information below.
diffViewerPageView.js, _getNextAnchor is what ultimately gets called to find the next place to jump to.  Checking for !$anchor.hasClass('dimmed') in the if statement would take care of this if it's okay to always jump over them when they're dimmed (which seems reasonable to me).
That or a new ANCHOR_VISIBLE_CHUNK anchor type should be added with new or repurposed (some of the existing next/prev hotkeys could hit them all while others could skip hidden changes) hotkeys matched to the new anchor type.
#1 david
  • +Component-DiffViewer
#2 david
  • +PendingReview
  • +david
#3 david
Fixed in release-2.0.x (a5be474). Thanks!
  • -PendingReview