3255: Change Password panel should be disabled or removed if supports_change_password is False
- Review Board
|mrc***@gmai***** (Google Code) (Is this you? Claim this profile.)|
|May 12, 2014|
What version are you running? 2.0 beta 3 (dev) What's the URL of the page containing the problem? http://localhost:8888/account/preferences/#authentication What steps will reproduce the problem? 1. Enable an authentication backend that has supports_change_password to False 2. Go to My Account, select Authentication. What is the expected output? What do you see instead? The Change Password panel is displayed and editable. If submitted, results in a 500 (traceback below). I would expect either the option to be removed or the panel disabled with a definable explanatory message. What operating system are you using? What browser? OS X, Firefox Nightly. Please provide any additional information below. Traceback (most recent call last): File "/Users/mcote/projects/reviewboard-latest/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/core/handlers/base.py", line 114, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/Users/mcote/projects/reviewboard-latest/lib/python2.7/site-packages/Django-1.6.2-py2.7.egg/django/contrib/auth/decorators.py", line 22, in _wrapped_view return view_func(request, *args, **kwargs) File "/Users/mcote/projects/reviewboard-latest/src/reviewboard/reviewboard/accounts/views.py", line 85, in user_preferences form.save() File "/Users/mcote/projects/reviewboard-latest/src/reviewboard/reviewboard/accounts/forms/pages.py", line 200, in save backend.update_password(self.user, self.cleaned_data['password1']) File "/Users/mcote/projects/reviewboard-latest/src/reviewboard/reviewboard/accounts/backends.py", line 69, in update_password raise NotImplementedError NotImplementedError
#3 vly****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'll take a look at this (Vlad).
Fixed in release-2.0.x (17cc9ce). Thanks!