3253: post-review without US locale fails

Kenny.M********@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 19, 2014
What version are you running?

What's the URL of the page containing the problem?
post-review --server=<SERVER> --output-diff

What steps will reproduce the problem?
1. Setup system with en_CA.UTF-8 UTF-8 (no en_US.UTF-8)
2. Setup /etc/locale.conf with LANG=en_CA.UTF-8
2.1. Optionally set LANGUAGE=en_CA.UTF-8 as well
3. Attempt to post a review.

What is the expected output?
Successful post

What do you see instead?

"The generated diff file was empty. This usually means no files were
modified in this change."

What operating system are you using? What browser?

Arch Linux

Please provide any additional information below.

When you add --output-diff the following is included:

--- __FILENAME__	(revision perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = "en_US.UTF-8",
	LC_ALL = "en_US.UTF-8",
	LANG = "en_CA.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)

'perl -e exit' works fine. Tried with and without LANGUAGE set.

Only workaround was to add the en_US.UTF-8 locale to my system.
#1 david
What version control system are you using?

Can you run with --debug and attach the output?
  • +NeedInfo
#2 david
  • +Component-RBTools
#3 Kenny.M********@gmai***** (Google Code) (Is this you? Claim this profile.)
Debug log attached.

I'm using git-svn (git local, svn backend). As you can see the diff is not actually empty, it's just not in proper diff format due to the tool not being able to figure out the initial revision.
  • +
    $ post-review --server=__ --debug --tracking-branch=__
    >>> RBTools 0.5.3
    >>> Python 2.7.6 (default, Nov 26 2013, 12:52:49) 
    [GCC 4.8.2]
    >>> Running on Linux-3.12.9-2-ARCH-x86_64-with-glibc2.2.5
    >>> Home = /home/kenny
    >>> Current Directory = /home/kenny/projects/__
    >>> Checking the repository type. Errors shown below are mostly harmless.
    DEBUG:root:Checking for a Subversion repository...
    DEBUG:root:Running: svn info --non-interactive
    DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
    svn: warning: cannot set LC_CTYPE locale
    svn: warning: environment variable LC_ALL is en_US.UTF-8
    svn: warning: please check that your locale name is correct
    svn: E155007: '/home/kenny/projects/__' is not a working copy
    DEBUG:root:Checking for a Git repository...
    DEBUG:root:Running: git rev-parse --git-dir
    DEBUG:root:Running: git config core.bare
    DEBUG:root:Running: git rev-parse --show-toplevel
    DEBUG:root:Running: git symbolic-ref -q HEAD
    DEBUG:root:Running: git svn info
#4 david
Thanks for the info. We'll get this fixed soon.
  • -NeedInfo
  • +david
#5 david
Fixed in release-0.5.x (7bf376c). Thanks!
  • -Started
#6 Kenny.M********@gmai***** (Google Code) (Is this you? Claim this profile.)
Awesome. Thank you!