3187: check_install function does not tell what is wrong

adam.b*******@globalspor*********** (Google Code) (Is this you? Claim this profile.)
March 16, 2014
What version are you running?
RBTools 0.5.3

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Have p4 client outside system $PATH
2. Run post-review with valid changelist from Eclipse IDE
3. Scratch an itch wondering why Perforce repo is not recognised as valid one 

What is the expected output? What do you see instead?
An error message telling that post-review was not able to execute p4 command, because it's not in a (system) $PATH location.

What operating system are you using? What browser?
MacOS X 10.7

Please provide any additional information below.

It was quite a bummer, because I've got p4 in my $PATH set in .bash_profile, but not in system-wide $PATH. As a result all commands executed from terminal worked, but post-review fired from Eclipse (using p4reviewboard plugin) failed without any useful error. The error message I've got was "No supported repository could be accessed at the supplied url." or "The current directory does not contain a checkout from a supported source code repository." which confused me even further.

I know, my bad installing p4 wrong, but it took me several hours of debugging and hacking Python code to find out what is actually wrong. A simple error message that "p4 help" command was not executed would be useful. On the other hand testing whether particular VCS is available by executing it's commands feels hacky.
#1 david
  • +Component-RBTools
#2 david
  • +EasyFix
#3 david
  • +PendingReview
#4 david
Fixed in rbtools master (d66be16). Thanks!
  • -PendingReview