3173: cannot compare several couple of clearcase file revision using --revision-range

nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 10, 2014
What version are you running?
rbtools 0.5.1

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. create a review containing at least 2 files with old and new revision
$ post-review --revision-range="file1@@/main/branch/1:file1@@/main/branch/2;file2@@/main/branch/3:file2@@/main/branch/4

What is the expected output? What do you see instead?
in source code delimiter token is ";"
but it does not build a list of revision range
#1 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
fix proposal
#3 Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.)
This solution breaks forward compatibility. There is a bug in documentation. The patch was already proposed here: https://reviews.reviewboard.org/r/5158/. Semicolon should be used by both: revisions and files.
#4 david
Well, now is the perfect time to think about this, since we're planning on breaking compatibility now to improve consistency across the board: https://reviewboard.hackpad.com/RBTools-Diff-Behavior-gRwNAvl3SzJ

Your input on the best ways to handle clearcase for this would be *much* appreciated. Ideally we could have users just specify a target as the revision (whether it's file@version pairs, a label, or a branch name) but I don't know how we would parse out which is which. I sent this page out to the reviewboard@ and reviewboard-dev@ mailing lists but haven't had any response yet.
#5 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
imho using the same delimiter for file and revision is a little bit confusing for user, when there are at least 2 files, how to differentiate if new revision of file N or old revision of file N+1. Moreover as seen in 5154 code review comments,  exception can be caught if split does not return 2 revision parts
I was not aware about --revision-range rework, so we will comment it.
we have another patch to support --ucm-activity and so another way to generate diff when using clearcase. I will post it next Thursday.
#6 nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
For close term, the documentation should be fixed, as proposed Jan in #5158 but example should include several files.
For long term, I have proposed some comments on your hackpad page
#7 david
Updated the docs in release-0.5.x (6569c1e). We'll be redoing the command-line interface for posting files and revisions for 0.6.
  • +Fixed