3163: --guess-summary should always use the first unpushed commit message from the branch.

fish****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 29, 2014
What version are you running?
Review Board 1.7.11
RBTools 0.5.2

What's the URL of the page this enhancement relates to, if any?

Describe the enhancement and the motivation for it.
When I have already made a review and use post-review to post an update to the review, it always changes the summary message to my latest commit message.  This usually doesn't make sense since my initial commit is more informative as a summary and the trailing commits are usually whitespace and grammar fixes.  --guess-summary should either not update the summary of an existing review or always use the first unpushed commit message from the branch.  

What operating system are you using? What browser?
Firefox 25.0

Please provide any additional information below.
I am dealing with this issue because my system has GUESS_SUMMARY=1 set in the .reviewboardrc by our compliance system. I can't just turn it off, even though I would like to because it gets re-enabled immediately.  I have been working around this by manually editing the summary after posting, or with squashing when it is a smaller commit.  I still think that logically the guess would be more accurate when pulling in from the first commit message when guessing the summary.
#1 david
  • +Component-RBTools
#2 david
  • +PendingReview
  • +david
#3 david
Fixed in rbtools master (b28c708). This will ship with 0.6
  • -PendingReview