3160: "Add comment" should be "New comment" in diff view

goo***@keithmo******* (Google Code) (Is this you? Claim this profile.)
Dec. 9, 2013
1426 
What version are you running? 1.7.12


What's the URL of the page this enhancement relates to, if any? http://site/r/1/diff/

Describe the enhancement and the motivation for it.
1. Person A posts a comment/review
2. Person B clicks on the blue bubble or on the same line number
3. Person B sees the previous comment in a blue box and a green box ready for input that says "Add comment".
3. Person B is confused on whether the green box is a reply or a new comment.

I would expect that the title of the green box is "New comment", as "Add comment" can be read as adding a comment/reply to the review comment seen in the blue box.

What operating system are you using? What browser? Windows 7, Firefox

Please provide any additional information below.

This is related to issue 1426, but I feel it is a separate issue (issue 1426 is about the confusion when clicking the reply button, this about the confusion on whether you need to click the reply button or whether the nice big text box is already a reply).

I plan to address this in a translation file for now (along with translating "Submitted" to "Completed", but I can understand that that may not be universally better), but having it more clear in the actual application would be preferred.
david
#1 david 
I'm going to merge this, because I think any solution to 1426 will need to involve a redesign of this whole UI. I'll make sure that that bug report has your observations as well.
#2 goo***@keithmo******* (Google Code) (Is this you? Claim this profile.) 
Thank you for your attention.

I understand your desire to merge the issues and am not objecting to that action. However, I want to reiterate my reasoning for purposely separating it:

As you mention, the solution to issue 1426 would be a major undertaking.  _This_ issue, however, would be a simple text substitution and would be beneficial with or without any further work on issue 1426.

I only pointed out issue 1426 at all, as I thought separately making this change would actually be a quick _improvement_ (not complete fix) toward addressing the confusion mentioned in issue 1426.
david
#3 david 
I'm not sure there's really a tremendous difference between the language, but it may make some improvement. I'll push a change to do this on the master branch (2.0+) but I'm not sure about making a UI change like this in the 1.7.x releases.