3159: ReviewBoard in violation of GPL

gregor*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 9, 2013 
What version are you running?

Git HEAD

reviewboard/scmtools/hg.py imports the Mercurial Python API and uses it. According to http://mercurial.selenic.com/wiki/License, this makes hg.py a "derived work" and subject to the GPL. Unfortunately, I could find no reference to the GPL in the source tree much less this file, so ReviewBoard is in violation of the GPL.
chipx86
#1 chipx86 
Hrm.. we'll get this fixed right away. Fortunately, not much of our support uses their module, and we can just call out to the command line instead.
  • +Confirmed
  • -Priority-Medium
    +Priority-Critical
chipx86
#2 chipx86 
Status update: I have this rewritten and am just debugging an issue I'm hitting. I'll be backporting this to older branches/releases. It will probably be in the tree tomorrow.

To any copyright holders who stumble across this, my sincerest apologies. This was an oversight when we first took the code using the hg module, and as GPL'd Python modules are not as common, and it never came up until now, it was just missed. Fortunately, usage was minimal (it's just being used to cat files in a repository), and easily fixed.
chipx86
#3 chipx86 
Fixed, and new releases will go out tomorrow with a rewritten Mercurial backend.
  • -Confirmed
    +Fixed